Seeking feedback on my proposed Apache Thrift generator improvements

Hi there,

I’ve prepared some improvements to erlang generator in Apache Thrift. Before asking to merge, I’d like to ask try my fork anyone who use thrift and give a feedback.

Improvements incudes:

  • Mark exception declaration with ‘exception’ in commentary
  • Mark enum declaration with ‘enum’ in commentary
  • Generate type for typedef declaration, use generated type instead of base type in declaration
  • Generate type for enum values, type consist of declared values. Use constant names in type declaration
  • Avoid integer type as enum value type, use generated type instead
  • Avoid magic numbers for enum as default values, use enum’s constant name instead
  • Introduce nominal types (Erlang 28+)
3 Likes