Starting to Help with Erlang Source Code, compile issues

MessageMap · May 27, 2022, 9:00pm

I’m starting to look at helping with source code updated, I started looking at issue:

Common Test "eating" stacktraces

opened 05:13PM - 15 Feb 22 UTC

team:PS help wanted

Hi! We noticed that Common Test does not preserve stacktraces for throws, but… it does for errors. This can complicate debugging. Some occurrences where this happens: https://github.com/erlang/otp/blob/master/lib/common_test/src/test_server.erl#L1581-L1585 https://github.com/erlang/otp/blob/master/lib/common_test/src/test_server.erl#L1649-L1652 https://github.com/erlang/otp/blob/master/lib/common_test/src/test_server.erl#L1792-L1793 For example, the following happens if I add a `error(foo)` in the `init_per_testcase/2`: ``` % rebar3 ct --suite apps/els_lsp/test/els_rename_SUITE.erl --case rename_module ===> Verifying dependencies... ===> Analyzing applications... ===> Compiling els_core ===> Compiling els_dap ===> Compiling els_lsp ===> Running Common Test suites... %%% els_rename_SUITE: %%% els_rename_SUITE ==> rename_module: SKIPPED %%% els_rename_SUITE ==> {tc_auto_skip, {failed, {els_rename_SUITE,init_per_testcase, {foo, [{els_rename_SUITE,init_per_testcase,2, [{file, "/Users/robertoaloi/git/github/erlang-ls/erlang_ls/apps/els_lsp/test/els_rename_SUITE.erl"}, {line,61}]}, {test_server,do_init_per_testcase,2, [{file,"test_server.erl"},{line,1553}]}, {test_server,run_test_case_eval1,6, [{file,"test_server.erl"},{line,1254}]}, {test_server,run_test_case_eval,9, [{file,"test_server.erl"},{line,1224}]}]}}}} ``` While this happens if I use `throw(foo)`: ``` % rebar3 ct --suite apps/els_lsp/test/els_rename_SUITE.erl --case rename_module ===> Verifying dependencies... ===> Analyzing applications... ===> Compiling els_core ===> Compiling els_dap ===> Compiling els_lsp ===> Running Common Test suites... %%% els_rename_SUITE: %%% els_rename_SUITE ==> rename_module: SKIPPED %%% els_rename_SUITE ==> {tc_auto_skip,{failed,{els_rename_SUITE,init_per_testcase,foo}}} ``` We were wondering if there's any specific reason behind this behaviour.

So I pulled down a forked version of code and looking to do an initial build,
My git log from may branch

commit 873912bf8ab4def4a23dedb55389a374381422b8 (HEAD -> 5719_CommonTest_eating_stacktraces, origin/maint, maint)
Merge: c1409c3a9e e7a44a7447
Author: Sverker Eriksson <sverker@erlang.org>
Date:   Wed May 25 21:12:52 2022 +0200

    Merge PR-5987 from sverker/25/hopeful-in-fun-env/OTP-18093
    
    Accept incorrectly encoded fun containing export fun or bitstring

My steps for compiling are using default options:

 ./configure --prefix=/tmp/local_erl

But when I run make I get:

 LD	/home/src/otp/bin/x86_64-pc-linux-gnu/beam.jit
obj/x86_64-pc-linux-gnu/opt/jit/erl_db.o: In function `erts_rwmtx_size':
/home/src/otp/erts/emulator/beam/erl_threads.h:1889: undefined reference to `ethr_rwmutex_size'
/home/src/otp/erts/emulator/beam/erl_threads.h:1889: undefined reference to `ethr_rwmutex_size'
obj/x86_64-pc-linux-gnu/opt/jit/erl_db_hash.o: In function `erts_rwmtx_size':
/home/src/otp/erts/emulator/beam/erl_threads.h:1889: undefined reference to `ethr_rwmutex_size'
/home/src/otp/erts/emulator/beam/erl_threads.h:1889: undefined reference to `ethr_rwmutex_size'
/home/src/otp/erts/emulator/beam/erl_threads.h:1889: undefined reference to `ethr_rwmutex_size'
obj/x86_64-pc-linux-gnu/opt/jit/erl_db_hash.o:/home/src/otp/erts/emulator/beam/erl_threads.h:1889: more undefined references to `ethr_rwmutex_size' follow
collect2: error: ld returned 1 exit status
make[4]: *** [x86_64-pc-linux-gnu/Makefile:1254: /home/src/otp/bin/x86_64-pc-linux-gnu/beam.jit] Error 1
make[4]: Leaving directory '/home/src/otp/erts/emulator'
make[3]: *** [/home/src/otp/make/run_make.mk:35: opt] Error 2
make[3]: Leaving directory '/home/src/otp/erts/emulator'
make[2]: *** [Makefile:45: opt] Error 2
make[2]: Leaving directory '/home/src/otp/erts'
make[1]: *** [Makefile:60: jit] Error 2
make[1]: Leaving directory '/home/src/otp/erts'
make: *** [Makefile:496: emulator] Error 2

Wondering what I’m missing to do a pre-code change compile and install, Note: I get the same thing from master.

Also c++ files have not been updated since Feb 15.

Thanks for the help and getting going.

max-au · May 28, 2022, 7:47pm

Ensure you have environment variable exported to the root of your erl tree:

ERL_TOP=`pwd`

It appears to point at /home/src/otp, which makes me think you have a Linux user named src.

MessageMap · May 29, 2022, 1:09pm

I check and still was not working, so I changed to Ubuntu and followed required install stuff from the dockerfile run: otp/Dockerfile.ubuntu-base at maint · erlang/otp · GitHub

that is working fine.

Last question is when I compile to test the code. my io:format calls from the compiled erl engine look to be removed or something.

is there away to compile erlang in a “DEBUG” format so you get more verbose logging on run?

Thanks for the help, Just onboarding into coding on the erlang engine.

garazdawi · May 29, 2022, 6:23pm

Common Test (the test framework used to test Erlang/OTP) captures all io:format calls and places them in the html log for that testcase. So I think that is where you want to look for the missing io:formats.

MessageMap · May 29, 2022, 6:24pm

Thanks Garazdawi, I found that when doing some more digging on the html files. Thanks for all the help.

But I was able to get my first PR out to erlang to fix an issue though

github.com/erlang/otp

5719 - Adding Stacktrace to thrown

erlang:maint ← MessageMap:5719_CommonTest_eating_stacktraces

opened 06:19PM - 29 May 22 UTC

MessageMap

+1 -1

this commit fixes #5719 New Stacktrace with thrown is: ``` ===> Running Comm…on Test suites... %%% db_data_type_SUITE: %%% db_data_type_SUITE ==> init_per_suite: FAILED %%% db_data_type_SUITE ==> {thrown, {foo, [{db_data_type_SUITE,init_per_suite,1, [{file, "/home/adamsbd/src/infratracks/common_tests/db_data_type_SUITE.erl"}, {line,44}]}, {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]}, {test_server,run_test_case_eval1,6, [{file,"test_server.erl"},{line,1379}]}, {test_server,run_test_case_eval,9, [{file,"test_server.erl"},{line,1223}]}]}} ``` no change to without Thrown and Normal Error: ``` ===> Running Common Test suites... %%% db_data_type_SUITE: %%% db_data_type_SUITE ==> init_per_suite: FAILED %%% db_data_type_SUITE ==> {undef,[{db,connect,["DSN=sqlserver;UID=alladin;PWD=sesame",[]],[]}, {db_data_type_SUITE,init_per_suite,1, [{file,"/home/adamsbd/src/infratracks/common_tests/db_data_type_SUITE.erl"}, {line,43}]}, {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1782}]}, {test_server,run_test_case_eval1,6, [{file,"test_server.erl"},{line,1379}]}, {test_server,run_test_case_eval,9, [{file,"test_server.erl"},{line,1223}]}]}

“small change but steps in learning the process”

MessageMap · May 29, 2022, 8:06pm

Moved my listing of comments related to PR and Issue to the github issue. since compiling source code is good to go now.

Thanks again